Jakub Narebski wrote:
I'd like to do away with need for git_cmd_str(), but unfortunately it is needed in a place where git has to form pipeline, namely in creating externally compressed snapshot (in git_snapshot), and to redirect stderr to /dev/null in git_object.
git_objects's use of 2> /dev/null won't be necessary since the Git::Repo API uses cat-file --batch-check, which doesn't (well, shouldn't) write on stderr.
If the use of shell command lines in git_snapshot bothers us enough, we can (a) create the pipe ourselves and just have it not work on Windows, (b) create it ourselves and spend a lot of time working around Windows' horribly borked API, or (c) use Perl's Zlib/Bzip2/LZO libraries. If anything I'm in favor of (c), though it makes installation harder if you want compressed tarballs. I'm fine with leaving it as is.
-- Lea -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
