2008/6/16 Catalin Marinas <catalin.marinas@xxxxxxxxx>:
> 2008/6/14 Karl Hasselström <kha@xxxxxxxxxxx>:
>> On 2008-06-14 08:28:33 +0100, Catalin Marinas wrote:
>> You don't remove the old parse_rev() and git_id(), and particularly
>> the latter has a lot of callers. Meaning that the rest of StGit still
>> speaks the old syntax.
>
> I thought about removing them when we convert the commands to the new
> infrastructure. In the meantime, I can rewrite git_id to use
> git_commit directly. The parse_rev is only used by the 'pick' command
> (and git_id). I'll have a look at these functions.
Done that - git_id/parse_rev now use the new id mechanism. Eventually
we'll drop git_id once all the commands are converted.
>>> -directory = DirectoryHasRepository()
>>> +directory = common.DirectoryHasRepositoryLib()
>>> options = [make_option('-b', '--branch',
>>> help = 'use BRANCH instead of the default one')]
>>
>> Couldn't we kill this option? (And in the process, the branch argument
>> to git_sha1.)
>
> No problem with the option but I would like to keep the branch
> argument to git_sha1. There might be cases where it is used like
> picking multiple patches and I only specify one -B option to 'pick'.
What about supporting patch ranges with the new id format, something like:
branch:patch1..patch2,patch3
or
branch:patch1..patch2 branch:patch3
The following can be valid as well but patch3 may be on a different branch:
branch:patch1..patch2 patch3
This way we could get rid of many --branch options.
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
