Hi,
While I was playing in the stash area and with "reflog expire" I was
surprised by the fact that "never" is not always never. For example,
approxidate("never") returns 4294960096 for my timezone (CET-2), it
loops with all negative timezones.
I fixed it by replacing date_never() with this one:
static void date_never(struct tm *tm, int *num)
{
time_t n = 0;
localtime_r(&n, tm);
}
but I not sure this is the right fix. Better idea?
If you want to try yourself, the following test case should trigger
the problem.
diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh
index 73f830d..b07d7bd 100755
--- a/t/t1410-reflog.sh
+++ b/t/t1410-reflog.sh
@@ -158,6 +158,17 @@ test_expect_success 'reflog expire' '
check_fsck "dangling commit $K"
'
+test_expect_success 'reflog expire --expire=never' '
+
+ TZ=CET-2 &&
+ git reflog expire --expire=never \
+ --stale-fix \
+ --all &&
+
+ loglen=$(wc -l <.git/logs/refs/heads/master) &&
+ test $loglen = 2
+'
+
test_expect_success 'prune and fsck' '
git prune &&
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
