Re: [PATCH 3/3] The "curl" executable is no longer required

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 15 June 2008, Jakub Narebski wrote:
> "David Symonds" <dsymonds@xxxxxxxxx> writes:
> > On Sun, Jun 15, 2008 at 8:16 PM, Johan Herland <johan@xxxxxxxxxxx> 
wrote:
> > > diff --git a/git.spec.in b/git.spec.in
> > > index 97a26be..d946bb1 100644
> > > --- a/git.spec.in
> > > +++ b/git.spec.in
> > > @@ -12,7 +12,7 @@ BuildRequires:        zlib-devel >= 1.2,
> > > openssl-devel, curl-devel, expat-devel, gettex
> > >  BuildRoot:    
> > > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> > >
> > >  Requires:      perl-Git = %{version}-%{release}
> > > -Requires:      zlib >= 1.2, rsync, curl, less, openssh-clients,
> > > expat +Requires:      zlib >= 1.2, rsync, less, openssh-clients,
> > > expat Provides:      git-core = %{version}-%{release}
> > >  Obsoletes:     git-core <= 1.5.4.2
> > >  Obsoletes:     git-p4
> >
> > Shouldn't libcurl still be listed as a requirement? Or is it
> > statically linked?
>
> It is not necessary to enumerate simple library dependencies, as
> rpmbuild _detects_ those dependencies during building binary RPMS.
> Only unusual requirements (on programs (tools) or on specific version
> of library) are needed to be added in Requires header.
>
> This has nothing to do with BuildRequires.  Besides it worked without
> libcurl in Requires, so it should continue to work without it,
> isn't it?

Unfortunately I don't know this format at all. There are now two versions of 
the patch, one without "Requires: curl", and one where it's replaced 
by "Requires: libcurl". Someone with more RPM knowledge will have to 
determine which is right.

...Johan

-- 
Johan Herland, <johan@xxxxxxxxxxx>
www.herland.net
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux