Jeff King <peff@xxxxxxxx> writes: > On Fri, Jun 13, 2008 at 12:35:59AM +0200, Lea Wiemann wrote: > >> Only ignore whitespace errors in t/tNNNN-*.sh and the t/tNNNN >> subdirectories. Other files (like test libraries) should still be >> checked. > > Why? > > What is the difference between test-lib.sh and tNNNN-*.sh that makes one > subject to whitespace checking and the other not? Eventually we would want to make all of the t/*.sh not exempt from the whitespace rules. Some currently do have trailing whitespaces as part of their embedded test vectors, but there are many that are more carefully written to avoid trailing whitespaces, by marking the EOL explicitly with a non whitespace characters in the source, and running sed to produce the actual vector that is used in the test. That style is vastly preferrable than having actual lines that end with trailing whitespaces, because it makes it much clearer what is being fed to the scripts and what are expected output when reading the source. You do not have to "cat -e" to see what they exactly do. So I think this is one step in the right direction. I do not want to keep tNNNN-*.sh exemption forever. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
