Dubious format-patch options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Git-ites,

Hmmm... There are a ton of dubious options being accepted
by the "git format-patch" command due to it being a skinny
front to "git log".  Like, the -S and pick-axe crew:

Yeah, this is context-less, but my point is that we get
totally different behavior from the -S"string" here:

    $ git log -SC alt~1..HEAD
    commit bca87c386c8868664e64d397108b8e6deda1e574
    Author: Jon Loeliger <jdl@xxxxxxx>
    Date:   Thu Jun 12 17:57:57 2008 -0500

	C
versus

    $ git format-patch -SC alt~1..HEAD
    0001-C.patch
    0002-D.patch
    0003-Z.patch
    0004-F.patch

Oh yeah.

And --color is a cool thing too.  I mean, I was pleasantly
pleased with:

    $ git format-patch -1 --stdout --color master

But I seriously doubt that we _really_ want to send a
patch that has the embedded escape sequences in it:

    From: Jon Loeliger <jdl@xxxxxxx>
    Date: Thu, 12 Jun 2008 18:13:10 -0500
    Subject: [PATCH] F

    ---
     fileESC[m |    1 ESC[32m+ESC[m
     1 files changed, 1 insertions(+), 0 deletions(-)ESC[m

    ESC[1mdiff --git a/file b/fileESC[m
    ESC[1mindex 6ac15b9..65f21da 100644ESC[m
    ESC[1m--- a/fileESC[m
    ESC[1m+++ b/fileESC[m
    ESC[36m@@ -5,3 +5,4 @@ D
    ESC[m X
    ESC[m Y
    ESC[m Z
    ESC[mESC[32m+ESC[mESC[32mFESC[m
    -- 
    1.5.6.rc0.46.gd2b3

Oh yeah.  Another Vodka Tonic please while git-send-email that...

jdl
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux