Mike Hommey wrote: > On Wed, Jun 11, 2008 at 04:29:56PM -0500, Brandon Casey wrote: >> The stash makes use of git's reflog mechanism, but it is not a reflog >> in the traditional sense. Each entry is a state that the user explicitly >> requested git to remember. The stash is generally short-lived, but the >> user probably expects that a stash will continue to exist until it is >> explicitly deleted. So we should not expire stash entries. > > I wonder if it wouldn't make sense to have git reflog expire not expire > stashes *at all*. I mean, you don't necessarily cleanup your repo with > git gc, and you may end up killing your stashes with git reflog yourself > if you don't use the "magic" --exclude... How do you do it cleanly? I don't like the idea of a config option which must be set by default when a repository is created and I don't really like the idea of a hard-coded refs/stash in builtin-reflog.c. git-reflog is currently a generic command. I didn't mind teaching git-gc about stashes, but to a quasi-plumbing command like git-reflog it doesn't seem right. -brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
