-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Karl Hasselström wrote:
>> + if filename.endswith(".gz"):
>> + import gzip
>> + f = gzip.open(filename)
>> + pname = filename.replace(".gz", "")
>> + elif filename.endswith(".bz2"):
>> + import bz2
>> + f = bz2.BZ2File(filename, 'r')
>> + pname = filename.replace(".bz2", "")
>
> Some comments here:
>
> * By my reading of the docs, the second argument to BZ2File defaults
> to 'r' anyway, so you could omit it.
Done.
>
> * We try to use single quotes wherever possible (except when triple
> quoting). You're using a mix ...
I normally use single quotes too, but I've been doing a bunch of C programming
lately, so that's my excuse and I'm sticking with it. Replaced.
>
> * .replace() will happily replace anywhere in the string. Please
> consider using stgit.util.strip_suffix() instead.
Ah, didn't know about strip_suffix(). Done.
>
> And last but not least, it'd be terrific if you'd let me bully you
> into adding .gz and .bz2 test cases for t1800-import. :-)
>
I'll work on that. Can't do it right now, but I'll look at the test harness and see
what it'll take.
Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkhOh34ACgkQqA4JVb61b9ea9gCgoV1MZbT2F62WEkduOfmkgdP3
BwIAnApT1o+VttF4VRHJj4DkPmi/HXfm
=Uwho
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
