Hi, maybe s/do not exit/complain/? Because it still exits if the hashes are missing... > diff --git a/builtin-cat-file.c b/builtin-cat-file.c > index f8b3160..112b9db 100644 > --- a/builtin-cat-file.c > +++ b/builtin-cat-file.c > @@ -168,8 +168,11 @@ static int batch_one_object(const char *obj_name, int print_contents) > else > type = sha1_object_info(sha1, &size); > > - if (type <= 0) > - return 1; > + if (type <= 0) { > + printf("%s missing\n", obj_name); > + fflush(stdout); > + return 0; > + } Is it really intended that it returns 0 now? Further, should it not be an error("%s missin... instead? It is an error, isn't it? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html