Hi, On Mon, 9 Jun 2008, Thomas Rast wrote: > Johannes Schindelin wrote: > > > > On Fri, 6 Jun 2008, Jeff King wrote: > > > 2. It's not integrated into the git-add--interactive loop at all. > > > That is, I don't start out saying "I want to edit this diff." I > > > look at the diff while staging with "git add -p" and say "Oops, > > > I need to edit this hunk." So I think it is better implemented > > > as an "e" option in the hunk adding loop, with "git add -e" as > > > a shortcut. Or maybe there is simply room for both (and "git > > > add -e", rather than being a shortcut, just means "do this on > > > the _whole_ file"). > > > > This is very much on purpose. I do not like "git add -i" at all. It > > limits my work unduly. That's why I tried to change the hunk editing > > in git-gui once upon a time, but I never got round to fix that, and it > > does not work well with ssh either. > > > > So no, I do not want to use that perl script with that menu. I want > > to have the raw diff in a raw editor, where I can change the things I > > need to change. > > While there is obviously little point in trying to convince you, Oh, sorry, I really meant the "I do not want" literally. It is just me. That does not mean that your hunk editing from within add -i has no merit. It's just that this guy is not very interested in that feature. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
