On Sun, 8 Jun 2008, Johannes Schindelin wrote: > On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote: > > Dynamically sized arrays are gcc and C99 construct. Using them hurts > > portability to older compilers, although using them is nice in this case > > it is not desirable. This patch removes the only use of the construct > > in stop_progress_msg(); the function is about writing out a single line > > of a message, and the existing callers of this function feed messages > > of only bounded size anyway, so use of dynamic array is simply overkill. > > > > Signed-off-by: Boyd Lynn Gerber <gerberb@xxxxxxxxx> > > > > -- > > Boyd Gerber <gerberb@xxxxxxxxx> > > ZENEZ 1042 East Fort Union #135, Midvale Utah 84047 > > > > --- > > Do you really want to have your mail signature in the commit message, > particularly because... > > > [...] > > > > clear_progress_signal(); > > free(progress->throughput); > > -- > > 1.5.2.4 > > > > > > -- > > Boyd Gerber <gerberb@xxxxxxxxx> > > ZENEZ 1042 East Fort Union #135, Midvale Utah 84047 > > You repeat it at the end of the mail anyway? > > The patch looks fine to me, though. I put it in because in the git repo it is not their. Only in the email. It is fine to remove it. -- Boyd Gerber <gerberb@xxxxxxxxx> ZENEZ 1042 East Fort Union #135, Midvale Utah 84047 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
