On Sun, Jun 8, 2008 at 8:53 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Some tests may chdir around and when you hit test_done they may not be in > the directory directly under t/ anymore. I'd say that such a test is > ill-mannered, but we would want to protect ourselves against such mischief > somehow. Ah, I guess logging to /tmp/git-test-result was more reliable then. Any suggestions as to what is the best solution here? (We could for example save $PWD at the beginning of test-lib.sh.) > Also, this won't be an immediate issue, but we may want to lift the > ".NOTPARALLEL" limitation in t/Makefile sometime in the future. A handful > tests need to be adjusted for this change, as they currently refer their > test vectors in t/tXXXX/ as ../tXXXX, and with such a change, we would run > each test in "t/trash directory/t$$" where $$ is the pid, or something > like that. A single "test-results" file everybody races to append would > become unwieldy at that point. Something to keep in mind. Ah, yes, I was going to have each test log to their own file (test-results-$$) and then cat the result together, but I figured that since we are .NOTPARALLEL anyway it would be more efficient not to. I reckon that whenever we decide to make such a change it will be then that we modify this script, if it is included? -- Cheers, Sverre Rabbelier -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
