Hi,
On Sat, 7 Jun 2008, Junio C Hamano wrote:
> Alex Riesen <raa.lkml@xxxxxxxxx> writes:
>
> > Johannes Schindelin, Sat, Jun 07, 2008 17:04:14 +0200:
> >> - for (i = 0; i < main_cmds.cnt; i++) {
> >> + for (i = 0; i < main_cmds.cnt && i < 5; i++) {
> >
> > I accidentally considered "i" just the index in the global command
> > table. Of course it is better :)
>
> That confusion however shows how hacky the approach to clobber the
> main_cmds global table by stuffing other things in it and sorting,
> without saying "who cares, we will exit after we are done with this
> processing anyway". If this patch were for inclusion, such a comment
> should be there immediately before it starts to muck with the command
> table.
This patch is not meant for inclusion, as indicated by the "TOY PATCH"
prefix.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
