Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes: > > > When invoking Git commands though sudo against a bare repository > > with reflogs enabled we should attempt to record the actual user's > > information in the reflog, not the identity of the user sudo entered. > > > > For example when executing: > > > > sudo -u gitadm git --git-dir=/srv/git.git branch -f pu master > > > > We want record information about the caller of sudo, not gitadm. > > If you are using something esoteric like pseudo, isn't it too much to ask > to also use existing GIT_COMMITTER_NAME, or are there reasons why it is > not sufficient? The issue is when users run commands though sudo, but forget to set a value for GIT_COMMITTER_NAME/EMAIL, or to configure ~/.gitconfig in their personal account. Now git has to guess the values for these based on the gecos of getuid(), and getuid() is returning the uid of the service account sudo entered (gitadm), not the real user's account. So the reflogs show generic "GIT Admin" and not who it was. Eh, I'm myself not entirely happy with the patch. It honors the real user's $HOME/.gitconfig user.name/email settings and not the SUDO_UID data. I'd almost prefer favoring SUDO_UID over whatever we inherit in from the enviroment or from $HOME/.gitconfig when it comes to committer identity. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
