Hi,
On Fri, 6 Jun 2008, Olivier Marin wrote:
> Johannes Schindelin a écrit :
> >
> > +int edit_patch(int argc, const char **argv, const char *prefix)
> > +{
>
> [...]
>
> > + if (!result)
> > + result = run_command(&child);
> > + free(child.argv);
> > +
> > + launch_editor(file, NULL, NULL);
>
> Here, it does not launch the editor I defined with core.editor because
> you call edit_patch() before calling git_config() in cmd_add().
Will fix.
> Also, wouldn't be better to have the edit_patch stuff in
> add--interactive instead ? It seems to work the same way than the
> --patch option.
Actually, no. It does something completely different. For example, it
avoids calling a perl script. At least as long as your editor is not a
Perl script.
Ciao,
Dscho
