Rafael Garcia-Suarez <rgarciasuarez@xxxxxxxxx> writes: > git_blame is dead code. It's possible to plug it in place of > git_blame2, but I don't know whether anyone does still that, > because git_blame2 can now be considered stable enough, I think. First, the two competing subroutines, git_blame and git_blame2 are from the time when there were two competing 'blame' implementations, respectively git-annotate (in Perl) and git-blame. git-blame won, and nowadays git-annotate is builtin alias passing '-c' option (Use the same output mode as git-annotate) to git-blame. git_blame and git_blame2 had not only different backend, but have different output as well. git_blame uses more columns, showing more info at first glance, while git_blame2 is simpler and less cluttered. That said, removing git_blame is a good idea (there was even some patch on this mailing list doing that, but IIRC it was part of larger series, and somehow got dropped, at least for mainline gitweb). There is always history if we want to check how its output looked like. Acked-by: Jakub Narebski <jnareb@xxxxxxxxx> (FWIW, as I am not gitweb maintainer). -- Jakub Narebski Poland ShadeHawk on #git -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
