s/Iterface/Interface/ fredagen den 23 maj 2008 22.34.14 skrev Florian Koeberle: > Signed-off-by: Florian Koeberle <florianskarten@xxxxxx> > --- > .../src/org/spearce/jgit/treewalk/rules/Rules.java | 99 ++++++++++++++++++++ > 1 files changed, 99 insertions(+), 0 deletions(-) > create mode 100644 org.spearce.jgit/src/org/spearce/jgit/treewalk/rules/Rules.java > > diff --git a/org.spearce.jgit/src/org/spearce/jgit/treewalk/rules/Rules.java b/org.spearce.jgit/src/org/spearce/jgit/treewalk/rules/Rules.java > + public abstract boolean toIgnore(String fileName, boolean fileIsDirectory); Shouldn't this be shouldIgnore instead? toXXXX is a name of a converter as e.g. toString > + @Override > + public String toString() { > + return "ignore all rules"; Probably better with something like "Rules[IGNOREALL]" to distinguish it from other strings. The bracketed toString is common for method intended for debugging. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html