Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> writes: > builtin-read-tree has a read_cache_unmerged() which is useful for other > builtins, for example builtin-merge uses it as well. Move it to > read-cache.c to avoid code duplication. Looks good, but as a public interface probably it needs a few lines of comment in front of the function's definition to describe what it is used for. Perhaps like... /* * Read the index file that is potentially unmerged into given * index_state, dropping any unmerged entries. Returns true is * the index is unmerged. Callers who want to refuse to work * from an unmerged state can call this and check its return value, * instead of calling read_cache(). */ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
