Re: [StGIT PATCH 5/5] Add stack creation and deletion support to the new infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The commit message is misleading. What this patch does is make "stg
init" _use_ the new-infrastructure stack init support added in your
previous patches.

On 2008-06-04 22:13:52 +0100, Catalin Marinas wrote:

> diff --git a/stgit/commands/init.py b/stgit/commands/init.py
> index 475a4ce..b68acd7 100644
> --- a/stgit/commands/init.py
> +++ b/stgit/commands/init.py
> @@ -16,13 +16,8 @@ along with this program; if not, write to the Free Software
>  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
>  """
>  
> -import sys, os
> -from optparse import OptionParser, make_option
> -
> -from stgit.commands.common import *
> -from stgit.utils import *
> -from stgit import stack, git
> -
> +from stgit.commands import common
> +from stgit.lib import stack

Lots of imports gone, and the remaining ones aren't spilled directly
into the local namespace. Very nice.

> -    crt_series.init()
> +    stack.Stack.initialise(directory.repository)

This would need minor tweaking if you decide to take my advice for
4/5.

-- 
Karl Hasselström, kha@xxxxxxxxxxx
      www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux