It appears that git-blame's returned group size can be wrong,
inducing the table display to be completely broken.
For gitweb to cope with that in a more robust manner, we can
drop the "rowspan" argument to the first <td> containing
the blame commit id, and just put empty cells instead,
whenever we have nothing to print in that column.
Signed-off-by: Rafael Garcia-Suarez <rgarciasuarez@xxxxxxxxx>
---
gitweb/gitweb.perl | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 472326f..c760884 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4218,7 +4218,6 @@ HTML
if ($group_size) {
print "<td class=\"sha1\"";
print " title=\"". esc_html($author) . ", $date\"";
- print " rowspan=\"$group_size\"" if ($group_size > 1);
print ">";
print $cgi->a({-href => href(action=>"commit",
hash=>$full_rev,
@@ -4226,6 +4225,9 @@ HTML
esc_html($rev));
print "</td>\n";
}
+ else {
+ print "<td class=\"sha1\"> </td>";
+ }
open (my $dd, "-|", git_cmd(), "rev-parse", '--', "$full_rev^")
or die_error(undef, "Open git-rev-parse failed");
my $parent_commit = <$dd>;
--
1.5.6.rc1
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
