Re: [PATCH] make commit --interactive lock index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alex Riesen wrote:
Paolo Bonzini, Thu, May 29, 2008 20:00:55 +0200:
The "if() die ()" thingie is already in builtin-commit.c, so we won't ever get a pathspec in the "add --interactive" case. If we do, something else has already been done incorrectly before -- not by the user but by the programmer.
What could that be?
Nothing, but it documents to whoever reads the code what is the path that will be taken. Anyway if it happened it would be very bad.

Why is a comment not enough?

I tend to use comment if it is more interesting to express the condition in English, and asserts if it is more interesting to express it as code.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux