Re: [PATCH] bisect: use "$GIT_DIR/BISECT_START" to check if we are bisecting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian Couder <chriscool@xxxxxxxxxxxxx> writes:

>> The reason you ignore an existing but empty BISECT_START file is...?
>
> ... that it should not happen, because this file is only written 
> in "bisect_start" and there its content comes either from the current HEAD 
> or from a previous not empty BISECT_START file.
>
> We might add a check for an empty BISECT_START file and warn in this case 
> that the file may have been corrupted, but that may be for another patch.

My question was more about "why are you acting as if distinction between
empty and nonempty BISECT_START matters?"

Because you "echo $start_head >$GIT_DIR/BISECT_START", this file will
always at least have a terminating LF even when the head is detached.
IOW, if it exists, it will never be empty, I think.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux