Jakub Narebski wrote:
On Sat, 24 May 2008, Nguyen Thai Ngoc Duy wrote:
On Sat, May 24, 2008 at 3:28 PM, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:
I think compatibility with grep (using GREP_COLOR) would be good idea,
and easily implemented.
I had no idea that variable existed.
Well, I have though that git always use external grep, so this would
be for free. After reading the patch more carefully it seems like it
isn't so.
Still, perhaps that would be a good idea, but I guess for later patch.
I can't help but think that colorization for external-grep systems only
would still be worthwhile, as the majority of git users are on such
systems. It'd still be a separate implementation from adding it to the
internal grep functionality anyways, so it's not as if work would be
lost by going half the way here.
--
Andreas Ericsson andreas.ericsson@xxxxxx
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
