Re: [PATCH 0/1] graph API: always print 'M' for merge commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote (2008-05-24 18:28 -0700):

> Adam Simpkins <adam@xxxxxxxxxxxxxxxx> writes:
> 
> > Okay.  Here's a simple patch to restore the behavior of always
> > printing 'M' for merge commits, even if less than 2 parents are
> > shown in the graph.
> 
> I have to wonder if that is really necessary.  A merge commit, unless
> you amend it, always starts with "Merge ...", and I think it is enough
> clue of what the particular commit did.  Besides, I think letter "M"
> in the pictorial part of the graph simply looks rather ugly.
> 
> I would even suggest not to use 'M' at all, whether its parents are
> interesting or not.

I don't have strong opinions on this, although I prefer different
symbols for these conceptually different commits - in the current graph
view. But if in the future someone implements an option like
log.unicodegraph=true which displays the graph with nice Unicode chars,
then I think M's wouldn't quite fit there visually anymore.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux