On Sat, May 24, 2008 at 12:21:42AM -0400, Daniel Barkalow <barkalow@xxxxxxxxxxxx> wrote: > You might as well use unpack_trees() directly here, instead of running a > separate command. In fact, you might skip making a function here, and just > call unpack_trees() where you'd use it. (And maybe have a function to > initialize a struct unpack_tree_options to some common defaults to make it > easy to see what's being done.) Thanks for the suggestion, I did so; as a result now patch #1 and #3 are no longer necessary. (I haven't sent out a new series yet, but it's in git://repo.or.cz/git/vmiklos.git builtin-merge.) Maybe builtin-reset could use unpack_trees() directly as well? I don't know if it's just a question of "nobody did it yet", or there is some reason for not using unpack_trees() there.
Attachment:
pgpesvlumXYMH.pgp
Description: PGP signature
