Re: [ALTERNATIVE PATCH] diff file1 file2: do not default to --no-index inside a git repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> When calling "diff -- a b" where a exists in the index, but b does not,
> do not default to --no-index inside a git repository.
>
> For example,
>
> 	git mv a b && git diff a b
>
> would not have the expected result.

I think the rule should be much stricter and "git diff" should _not_ use
no-index if run in a repository without --no-index.

I also suspect that your updates to the testsuite are grossly inadequate.
Earlier "diff expect actual" was replaced with "git diff expect actual"
against my good taste (TM) in many tests, and they need to either be
replaced with "git diff --no-index" or (even better) "test_cmp".

No need to resend, as I did a rather unpleasant conversion of these places
back to "test_cmp" already, but I'd appreciate an extra set of eyeballs to
proofread that rather large fix to the testsuite.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux