2008/5/20 Karl Hasselström <kha@xxxxxxxxxxx>: > On 2008-05-20 18:19:02 +0100, Catalin Marinas wrote: >> I build release tarball from the directory under Git control and I >> always get a builtin_version.py generated. In my initial patch I had >> a check in setup.py for a .release file. I could add a check in >> write_builtin_version to ignore the extra .git stuff if I am making >> a release (only keep the tag name). > > Nah, easier to just change the order of the checks (try r2 before r1) > as I outlined. I'll whip up a patch. [...] > If you're exactly on a tagged commit, git-describe will return just > the name of that tag, so you don't need to do anything extra. Now that you mentioned this (I didn't know), is there a need to reverse steps r2 and r1? I always build the release from the current tag and the version should be clean. >> BTW, Git seems to use 6 characters for the current commit id and >> StGIT 5. Should we change this for consistency? > > Both git and we call git-describe with --abbrev=4, which I think means > "describe the commit uniquely with as few digits as possible, but no > less than four". So we'll get upgraded automatically when it becomes > necessary. OK, I didn't know this either. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
