Re: [PATCH 2/2] Add support for GIT_CEILING_DIRS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On May 14, 2008, at 3:23 AM, Johannes Schindelin wrote:

@@ -414,6 +415,37 @@ const char *setup_git_directory_gently(int *nongit_ok)
	if (!getcwd(cwd, sizeof(cwd)-1))
		die("Unable to read current working directory");

+	// Compute min_offset based on GIT_CEILING_DIRS.

We do not like C99 style comments. Remember, there are people who compile Git on something else than the super-latest Linux with cutting-edge GCC.

Out of curiosity, what environment these days doesn't allow C99 comments? I think I started programming roughly 10 years ago (granted, I didn't start with C, but I did C programming at least 8 years ago, if not earlier) and every environment I've ever used has supported those comments even in C89 mode.

I mean, I fully understand that git wants to be portable across all platforms, but it still makes me wonder if there's any environment that anybody actually uses these days that doesn't understand those comments when compiling C.

--
Kevin Ballard
http://kevin.sb.org
kevin@xxxxxx
http://www.tildesoft.com


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux