Re: [PATCH 2/5] Make mktag a builtin.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 12 May 2008, Brandon Casey wrote:

> Junio C Hamano wrote:
> > drafnel@xxxxxxxxx writes:
> > 
> >> From: Brandon Casey <drafnel@xxxxxxxxx>
> >>
> >> Signed-off-by: Brandon Casey <drafnel@xxxxxxxxx>
> > 
> >> @@ -306,6 +305,7 @@ BUILT_INS += git-fsck-objects$X
> >>  BUILT_INS += git-get-tar-commit-id$X
> >>  BUILT_INS += git-init$X
> >>  BUILT_INS += git-merge-subtree$X
> >> +BUILT_INS += git-mktag$X
> >>  BUILT_INS += git-peek-remote$X
> >>  BUILT_INS += git-repo-config$X
> >>  BUILT_INS += git-show$X
> >> @@ -423,6 +423,7 @@ LIB_OBJS += log-tree.o
> >>  LIB_OBJS += mailmap.o
> >>  LIB_OBJS += match-trees.o
> >>  LIB_OBJS += merge-file.o
> >> +LIB_OBJS += mktag.o
> > 
> > This is unusual for a builtin.  Why didn't it migrate to builtin-mktag?
> 
> I didn't know how to do it.
> 
> I was trying not to do a code move and a code change at the same time.

Why did you not consult Git's own history for guidance?  See e.g.

	$ git log next --diff-filter=A builtin-*.c

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux