Hello. I received "fatal: Out of memory, malloc failed" error when I tried to check in file of ~2.5G It can be argued that binary file of that size (or binary file altogether) has no place in version control anyways, but still I pursued it a bit more. In #git@freenode channel I received some hints and in the end I started running "git-hash-object -w images/filesystem_ext2.img.bz2" It would seem that sha1_file.c:write_sha1_file() has defined size variable as integer. This wraps around in "size = 8 + deflateBound(&stream, len+hdrlen);" and gives big number for mmap() mmap(NULL, 18446744071976239104, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = -1 ENOMEM (Cannot allocate memory) size is used in "stream.avail_out = size;" and zstream.avail_out seems to be unsigned int "uInt avail_out; /* remaining free space at next_out */" If size would be changed to unsigned would the max filesize be increased to ~4G or would it blow up elsewhere? Is git going to support >2G files or is having "everything that is needed to complete build process from beginning to bitter end" in version control something that git is not meant for? If latter is true then this would be pretty much pointless change. If former then changing 'size' to integer won't be enough anyways... Best Regards Janne Pänkälä -- Janne Pänkälä -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
