Re: [PATCH 3/4] Fix diff regression for submodules not checked out

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 4, 2008 at 2:45 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Junio C Hamano <gitster@xxxxxxxxx> writes:
>
>  > The second case is "not checked out -- treat me as unmodified", and the
>  > third case is "the user does not want the submodule there", and the latter
>  > is still reported as "removed".  That is exactly what your patch does.
>
>  Having looked at the code a bit more, I do not think we need the
>  three-kind distinction for this part.
>
>  The attached patch would be both sufficient and cleaner.  The real change
>  is a single-liner, and everything else is additional comment ;-)  I'd
>  follow it up with s/check_work_tree_entity/check_removed/ for
>  clarification.
>

Fine, it's cleaner.

-- 
Ping Yin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux