Jeff King <peff@xxxxxxxx> writes: > .... It seems like pp_title_line should perhaps just be checking > for fmt == CMIT_FMT_EMAIL, but I'm not sure if that would break anything > else,... Yeah, your patch obviously would fix the caller, as subject and after_subject should not be given unless you are doing FMT_EMAIL. But I also think we should not even look at subject and after_subject unless fmt is CMIT_FMT_EMAIL inside pp_title_line(). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
