Re: [PATCH] --color-words: Make the word characters configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin wrote (2008-05-03 15:03 +0100):

> Now, you can specify which characters are to be interpreted as word
> characters with "--color-words=A-Za-z", or by setting the config
> variable diff.wordCharacters.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> ---
> 
> 	I would have preferred an approach like this.

Unfortunately this does not work at all with other than Ascii
characters. It makes --color-words completely unusable for anything
other than Ascii text. Sorry.

Ping Yin's version has also the problem that UTF-8 multibyte characters
U+0080..U+10FFFF don't work in diff.nonwordchars. Fortunately the most
important word delimiters are in U+0000..U+007F (=Ascii) area so Ping's
version is perfectly usable with Unicode text. (Even the old
--color-words behaviour with only SPACE as non-word char was perfectly
usable with Unicode text.) I, too, would like to see Ping's patch series
merged in.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux