Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 30, 2008 at 6:37 PM, Jeff King <peff@xxxxxxxx> wrote:
>  Actually, thinking about this a bit more (and using it), I'm not sure
>  that the best rule for showing the committer is "differs from the
>  previous committer." For example, if I am building on Junio's git.git,
>  the committer name is shown, even though I have made many commits in
>  this repo already.
>
>  So if the goal is to show the committer name only when it "matters", I
>  don't think you have succeeded.
>
>  -Peff
>

On Wed, Apr 30, 2008 at 7:52 PM, Alex Riesen <raa.lkml@xxxxxxxxx> wrote:
>  I like the idea in general, but the implementation could be refined.
>  Maybe consider looking at user.name (whether the repo has an ident
>  set)? This is usually done conciously, and the user wont need this
>  reminder.

Maybe only show the committer ident when both happens:

1) the committer ident is different from the parent
2) the committer ident is set automatically

Santi

P.D.: Jeff, thanks for the amending patch.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux