Miklos Vajna wrote:
>Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
>> > Isn't the problem that git-daemon loses its connection to the syslog
>> > daemon when logrotate sighups syslog?
No.
>Right, but logrotate could send SIGHUP to git-daemon as well.
It could, but that's the reason one uses the openlog(3) interface to
syslog, to centralise logfilemanagement and *not* having to deal with
the intricacies of logfile rotation and the like. So it doesn't need
to. When you need logfile rotation, you're better off with using
openlog(3), and doing that the proper way means *NOT* closing and
reopening that everytime.
>> I have no idea, but other programs must have the same problem. I should
They don't. Your patch fixes the wrong problem. Please don't fix
something that wasn't broken in the first place.
>> have shown some diligence and researched that. Will do so now.
>I don't say that just one example justifies me, but here is an example:
>icald (google://openlog+sighup 2nd result) does this.
N.B. I've never had to close and reopen the openlog(3) syslog interface
in any of the daemons I've written.
The example you refer to of icald is where it directly writes to a
logfile, which is *not* what this patch was about, so please do not use
it as justification.
--
Sincerely, srb@xxxxxxx
Stephen R. van den Berg.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
