"Stephen R. van den Berg" <srb@xxxxxxx> writes:
> git-svn supports an experimental option --use-log-author which currently
> results in:
>
> Author: foobaruser <unknown>
I have a question about this. Is the "<unknown> coming from...
> This patches harmonises the result with cvsimport, and makes
> git-svn --use-log-author produce:
>
> Author: foobaruser <foobaruser>
> ...
> diff --git a/git-svn.perl b/git-svn.perl
> index b151049..846e739 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2434,6 +2434,9 @@ sub make_log_entry {
> } else {
> ($name, $email) = ($name_field, 'unknown');
> }
... this 'unknown' we see here?
> + if (!defined $email) {
> + $email = $name;
> + }
> }
I would think not -- if that is the case, the codepath you added as a fix
would not trigger. Which means in some other cases, the 'unknown' we see
above in the context also still happens. Is it a good thing? Maybe we
would also want to make it consistently do "somebody <somebody>" instead,
by doing...
} else {
$name = $name_field;
}
if (!defined $email) {
$email = $name;
}
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
