Before this patch something like: $ git rev-parse --verify <good-rev> <junk> worked whatever junk was as long as <good-rev> could be parsed correctly. This patch makes "git rev-parse --verify" error out when passed any junk after a good rev. Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> --- builtin-rev-parse.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) With this patch something like: $ git rev-parse --verify <good1> <good2> will still fail. For example: $ git rev-parse --verify v1.5.5 v1.4.0 9d831805195ba40b62f632acc6bb6e53d3ec9ee1 120530fb2e10679d9095e278c95c0e98c96f3080 fatal: Needed a single revision but it failed like that before. I don't know if I should make it work. diff --git a/builtin-rev-parse.c b/builtin-rev-parse.c index 9384a99..0e59707 100644 --- a/builtin-rev-parse.c +++ b/builtin-rev-parse.c @@ -576,11 +576,11 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix) show_rev(REVERSED, sha1, arg+1); continue; } + if (verify) + die_no_single_rev(quiet); as_is = 1; if (!show_file(arg)) continue; - if (verify) - die_no_single_rev(quiet); verify_filename(prefix, arg); } show_default(); -- 1.5.5.1.164.g3d51ee.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
