Re: [PATCH v2 04/13] Teach rebase interactive the mark command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Junio,

Junio C Hamano schrieb am Tue 22. Apr, 11:04 (-0700):
> Jörg Sommer <joerg@xxxxxxxxxxxx> writes:
> 
> > What do you think about this version:
> >
> > cleanup_before_quit () {
> > 	rm -rf "$DOTEST" &&
> > 	for ref in $(git for-each-ref --format='%(refname)' ${mark_prefix%/})
> > 	do
> > 		git update-ref -d "$ref" "$ref" || return 1
> > 	done
> > }
> 
> Yeah, except you would want to dqquote "${mark_prefix%/}" part.

Oh, yes.

> Also this being a "clean-up" phase, I wonder if we want to stop at the
> first error (e.g. should unremovable "$DOTEST" leave marks behind?

I think it should be the other way: unremovable marks should leave the
DOTEST behind. This way a rebase should refuse to start a new session and
stumble accross the old marks and it's possible to run git rebase --abort
after manually removing the marks.

Bye, Jörg.
-- 
Damit das Mögliche entsteht, muß immer wieder das Unmögliche versucht
werden.                                       (Hermann Hesse)

Attachment: signature.asc
Description: Digital signature http://en.wikipedia.org/wiki/OpenPGP


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux