Re: [RFC] Moving "git remote add --mirror blah" functionality to "git clone --bare --origin=blah"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ooo.  But I think that's the other way around.  It was prepared for that
purpose but people never followed through.  Check the archive around
commit 3894439 (Teach "git remote" a mirror mode, 2007-09-02).

Well, the thread is not very explicative. Neither is the commit log message. There is no info as to *why* it is useful.

After finding no particularly good info in the commit, and seeing that the functionality is unused within git's shell script porcelain, I wrote my RFC on the intuition that it is a failed experiment. (The rest of this message is also assuming this possibly wrong intuition).

--mirror" is close to useless: anyone who needs it 99% of the time
knows how to hack the config...

Eh, in that sense, "git remote" itself is useless, isn't it?

Hm, bad sentence on my side. My point was that my proposed improvements to clone:

  git clone --bare -o origin <url> foo.git

satisfy 99% of the usecase; you usually know beforehand if you're cloning for local development or for mirrors. Anyone who *still* needs --mirror after that (i.e. needs two mirror-mode remotes, or needs it on non-bare repositories), 99% of the time knows how to hack the config. Actually in the latter case (non-bare repos) he might have to hack the config soon, if Dscho's patch to forbid this is polished and goes in.

In the end, this piece of functionality is almost unused (surely unused within git's shell porcelain, if not in the wild) and is dubiously placed for two reasons:

1) If the point of git remote is to shield from the config, what the user will learn is that "git remote" is about "git branch -r" (maybe he'll also learn "refs/remotes/something"). Now instead you have an option that goes under "git remote" just because it creates remote.* configuration options. Indeed, "git remote add --mirror -f" will create *local* branches, so that "git branch -r" does not show them.

2) Similarly, "--mirror" suggests that the remote will go hand in hand with "git push" (that has the "--mirror" option, and this started my confusion) rather than "git fetch"/"git pull". Indeed, even after my patch[1] to add some DWIM functionality for mirrors to "git push", the user will need to hack the config file manually to activate the DWIM.

Instead, my proposed meaning of "git remote add --mirror" would fix both discrepancies...

Paolo

[1] http://marc.info/?l=git&m=120877130932254&w=2
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux