On 4/23/08, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Not all of this belongs in the commit messaage. > > > Acked-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > This does. > > A good general rule is: if you think it would be funny/strange to read > this message in the output of "git log", it should be changed. I felt uncomfortable modifying the message attached to Jeff's patch (which actually does pretty clearly explain what's going on), since it's not mine. If he wants to send me a better commit message, that'll be fine too. Have fun, Avery -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html