Le vendredi 18 avril 2008, Tordek a écrit :
> Signed-off-by: Guillermo O. Freschi <tordek@xxxxxxxxxxxxx>
> ---
> http.c | 35 ++++++++++-------------------------
> 1 files changed, 10 insertions(+), 25 deletions(-)
>
> diff --git a/http.c b/http.c
> index 256a5f1..cadc1bf 100644
> --- a/http.c
> +++ b/http.c
> @@ -100,39 +100,27 @@ static int http_options(const char *var, const
> char *value)
> }
>
> if (!strcmp("http.sslcert", var)) {
> - if (ssl_cert == NULL) {
> - if (!value)
> - return config_error_nonbool(var);
> - ssl_cert = xstrdup(value);
> - }
> + if (ssl_cert == NULL)
> + return git_config_string(&ssl_cert, var, value);
> return 0;
> }
Did you check that there is no compile warnings resulting from this ?
Did you read the last sentences of http://git.or.cz/gitwiki/Janitor ?
By the way it seems that your patch has spaces instead of tabs everywhere.
Thanks,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
