Re: gitweb: pathinfo feature breaks commitdiff/raw links

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



El 17/4/2008, a las 11:23, martin f krafft escribió:
Hello,

as per suggestion in gitweb.cgi, I put the following into my
gitweb.conf:

 $feature{'pathinfo'}{'default'} = [1];

This mostly works, but James Vega recently found a corner case where
this is broken: the raw link of a commitdiff page, such as

 http://git.madduck.net/v/code/mailplate.git?a=commitdiff;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e

suddenly becomes

 http://git.madduck.net/v/ARRAY(0xbc3b70)?a=commitdiff_plain;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e
                          ^^^^^^^^^^^^^^^
when the feature is turned on. It works when it's off.

I discussed this a bit on IRC, with the following bottom line:

 < jengelh> if you see ARRAY... in the url, and [1] in the source
 the wise Perl person says "ah, of course"

Unfortunately, I am neither wise nor a Perl person, so I resort to
just pointing this out to you and can offer to test any patches on
this live server.

Are you running an older version of gitweb? One which predates 7863c61?

Cheers,
Wincent



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux