On 4/16/08, Junio C Hamano <gitster@xxxxxxxxx> wrote: > apenwarr@xxxxxxxxx writes: > > This adds a From: line (based on the commit's author information) when > > sending to svn. It doesn't add if a From: or Signed-off-by: header already > > exists for that commit. > > I admit that I do not use git-svn, but I am confused. Where are you > adding that "From:"? You grab a commit log message out of git (which does > not have such "From:", add such a line at the beginning of the commit > message using the authorship information and send the resulting commit log > message to svn? Why? When git-svn copies a commit from git to svn, svn eats the authorship information; it always sets the svn author field to the username of the person logged into the svn server. With the (existing) --use-log-author option, git-svn will pull From: and Signed-off-by: lines from svn's log entries when pulling back into git, which helps with this problem. However, it only works with commits that have a Signed-off-by: or From: already included. The new option --add-author-from makes sure that every commit going into svn *does* have a From: or a Signed-off-by: by adding one based on the git Author field if it doesn't already exist. Combined with --use-log-author, this reduces the information loss in a round trip through the svn server. (And there's always a round trip, as "git-svn dcommit" throws away your pre-svn commits and replaces them with the commit it has put into, then pulled out of, svn.) Does that make sense? Thanks, Avery -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
