On Mon, 14 Apr 2008, Andi Kleen wrote: > David Miller <davem@xxxxxxxxxxxxx> writes: > > > > It's still largely free form, loose, and flexible. > > I think Al's point was that we need far more "free form, loose and > flexible" work for reviewing code. As in people going over trees and > just checking it for anything suspicious and going over existing code > and checking it for anything suspicious and going also over mailing > list patch posts. And also maintainers who appreciate such review. > > And checking it for anything suspicious does not mean running > only checkpatch.pl or even just sparse, but actually reading it > and trying to make sense of it. If you really want to get more such review, then it would be very useful when someone asks about some obtuse portion of kernel code or makes a suggested improvement, that the reviewer then not be flamed as being dense for not understanding the code or some kernel coding concept. It would be much better to treat it as an oppurtunity to educate rather than belittle, thus eventually enlarging the base of people who can assist with various aspects of kernel development. For what's supposed to be an open, engaging community, and which generally is, there sometimes seems to be some level of dismissal of newcomers (not sure it's intended that way but nevertheless it can tend to discourage newcomers from getting more involved). -Bill -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
