On Tue, Apr 15, 2008 at 03:43:10AM +0300, Heikki Orsila wrote: > On Mon, Apr 14, 2008 at 05:08:03PM -0700, Junio C Hamano wrote: > > > + * of git. Note, we use octal numbers. > > > */ > > > - sprintf(buf, "%d", shared_repository); > > > + sprintf(buf, "0%o", shared_repository); > > > > Unconditionally doing this makes the resulting repository unusable by git > > 1.5.5 and older, even when the user wanted to use the bog standard "git > > init --shared". You can limit the extent of damage if you continue > > writing PERM_GROUP and PERM_EVERYBODY out as 1 and 2, and use the new > > octal notation only when the user used the settings allowed only with new > > git. > > I submitted a new patch that should address all the points. Submitted another version that really fixes the o+w case. Forgot the 0664 mask there. Now it's 0666. -- Heikki Orsila heikki.orsila@xxxxxx http://www.iki.fi/shd -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
