Hi,
On Mon, 14 Apr 2008, Alberto Bertogli wrote:
> + if (fd < 0) {
> + error("can't open patch '%s': %s", arg,
> + strerror(errno));
> + return 1;
> + }
Do you absolutely want to retain the curly braces, and have two
statements? I would prefer "return error(...)", and if you absolutely
insist on a return 1: "return !!error(...)".
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
