Jörg Sommer <joerg@xxxxxxxxxxxx> writes: > is it expected that this test fails? I think you spotted a bug ;-) -i should only affect the way how you build the index. Unless the user does not ask for --allow-empty this should be prevented, I think. > diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh > index c0288f3..2c21428 100755 > --- a/t/t7501-commit.sh > +++ b/t/t7501-commit.sh > @@ -123,6 +123,18 @@ test_expect_success \ > "interactive add" \ > "echo 7 | git-commit --interactive | grep 'What now'" > > +cat >editor <<\EOF > +#!/bin/sh > +echo invalid commit > $1 > +EOF > +chmod 755 editor > + > +test_expect_success \ > + "interactive fails on empty index" \ > + "export VISUAL=./editor && > + test_must_fail git commit --interactive < /dev/null && > + unset VISUAL" > + -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html