On Fri, Apr 11, 2008 at 05:53:36PM -0700, Junio C Hamano wrote:
> That's not a "Warning" (which tends to mean "you can violate this if you
> know what you are doing"), but should be stronger than that. Something
> like (also notice the multi-line comment style --- the first line ends
> with "/*\n"):
>
> /*
> * NOTE NOTE NOTE!!
> *
> * Do not reorder this list; numerically written core.sharedrepository
> * in config files have always been valid, and you would break existing
> * repositories if you move these around.
> */
OK
> > enum sharedrepo {
> > PERM_UMASK = 0,
> > PERM_GROUP,
> > - PERM_EVERYBODY
> > + PERM_EVERYBODY,
> > + PERM_GROUP_READABLE,
> > + PERM_WORLD_READABLE,
> > };
>
> But I have to wonder if this patch is necessary.
It is necessary for us, and I suspect it will be useful in some
organizations. The situation is this:
* multiple groups on the same machine
* users may want to keep umask 0077 as the default
> Neither am I convinced if this set is sufficient.
It will be easy to add new groups if the need arises, but I can't see
many other useful combinations..
> For example, you may want to enforce "ug+rw,o=" in a repository. How
> would you do that?
Isn't that PERM_GROUP? The user always keeps u+rw for oneself.
> Perhaps if you really wanted to have such a fine grained control, you
> would be better off defining core.sharedrepository as a set/unset pair?
>
> core.sharedrepository = 0660,007 ;# ug+rw,o-rwx
>
> Or even stronger "set to this bit pattern"?
>
> core.sharedrepository = 0660 ;# ug=rw,o=
The latter approach is simpler and probably more understandable.
> (I think you would need to flip executable bit for directories if you go
> this route).
I can put x flag mode checking.
Do you accept these proposals? I can submit another patch.
--
Heikki Orsila Barbie's law:
heikki.orsila@xxxxxx "Math is hard, let's go shopping!"
http://www.iki.fi/shd
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
