On Tue, Mar 25, 2008 at 19:06:49 -0400, Jeff King wrote: > On Tue, Mar 25, 2008 at 08:31:16PM +0200, Teemu Likonen wrote: > > > By the way, 'git send-email --compose' does not add MIME headers to > > introductory message. All non-Ascii chars will output something > > undefined in receivers' end. > > > > I guess the right way would be to detect user's charset (locale) and add > > appropriate MIME headers. Also, the Subject field should be encoded if > > it contains non-Ascii characters. > > I just posted some patches to fix this; however, they always encode as > utf-8. I'm not sure what is the best way to find the user's encoding. > AIUI, locale environment variables are not enough, since, e.g., "en_US" > could come in iso8859-1 and utf-8 flavors. Is there a portable way to > figure this out? Should we be pulling it from .git/config? Neither the > commitEncoding nor the logOutputEncoding really makes sense to reuse. The portable way is to use the locale environment variables, but you have to read them via the libc locale interface. You set the LC_CTYPE locale category via setlocale (which will consult LC_CTYPE, LC_ALL and LANG environment AND the locale database) and than ask for charset using nl_langinfo(CODESET). To do the equivalent from the shell, call `locale charmap`. From perl, either use langinfo in I18N::Langinfo, or just use the ':locale' IO stream option provided by encoding pragma to read the file in unicode no matter what the locale encoding was (this is perl 5.8.<something> -- in older one, you'd have to use I18N::Langinfo anyway). -- Jan 'Bulb' Hudec <bulb@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
