Re: [PATCH v2 01/10] git-rebase.sh: Fix --merge --abort failures when path contains whitespace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 10, 2008 at 12:45:51AM -0700, Junio C Hamano wrote:
> Bryan Donlan <bdonlan@xxxxxxxxxxxx> writes:
[snip]
> > +	test_expect_success "rebase$type --abort" "
> > +		cd \"\$work_dir\" &&
> >  		# Clean up the state from the previous one
> > +		git reset --hard pre-rebase &&
> > +		test_must_fail git rebase$type master &&
> > +		test -d \"\$dotest\" &&
> > ...
> 
> this part would become a lot easier to read if you just stayed inside the
> original single quoted test script without introducing excessive
> backslashes.

Oh, wow, what was I thinking? I'll fix that up... it must've been rather
late at night when I wrote that or something :)

Also, I saw your note about changing the git-svn tests to single-quoting
rather than escaping everywhere - but only after I hit send. I'll roll
that into the v3 (and probably wait longer than this time, so people
have time to finish reviewing...)

Thanks,

Bryan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux